Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and cleanup for OpenOffice #601

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Fixes and cleanup for OpenOffice #601

merged 1 commit into from
Dec 29, 2015

Conversation

oscargus
Copy link
Contributor

Revert a minor error introduced in earlier fix.

Further cleanup, primarily getting rid of duplicated code and some Coverity warnings.

@oscargus oscargus added cleanup-ops status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers openoffice/libreoffice labels Dec 28, 2015
@koppor
Copy link
Member

koppor commented Dec 29, 2015

LGTM. I don't use the plugin and I think, no one else of the other developers do. Therefore, I fully trust you 🌴

koppor added a commit that referenced this pull request Dec 29, 2015
Fixes and cleanup for OpenOffice
@koppor koppor merged commit ef511b9 into JabRef:master Dec 29, 2015
@oscargus oscargus deleted the moreoo branch December 29, 2015 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-ops openoffice/libreoffice status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants